Dinesh

Results 20 comments of Dinesh

✨ Added evaluation logic for `describe nginx` in k8s-bench. 🧪 What this PR does: - Introduced basic `round()` usage to evaluate command output. - Modified function name from `round_` to...

I’ve removed the separate test_round_warning.py file and moved the test into numpy/core/tests/test_deprecations.py as suggested. The test now uses pytest.deprecated_call(match="deprecated") to reduce boilerplate.

Thanks for the feedback! 🙌 I’ll work on building NumPy locally and run the tests using spin before pushing again. Also, I’ll add the missing release note in the correct...

I've addressed all the feedback: 1. Fixed the RST format in the release note with proper double backticks 2. Fixed the function implementation in core.py to properly deprecate `round_` and...

@jorenham your issue changed to another pr due to some technical issue I'm sorry about that you can view here Dinesh-0813:fix-deprecate-ma-round #28917 sorry for the trouble

This PR renames the internal function `round_` to `round` in `numpy.ma.core`, aligning it with NumPy's naming conventions and improving clarity. Associated docstrings and usages have been updated accordingly.

👋 Hi everyone! I'm a first-time contributor to NumPy, and I’ve been working on [PR #28899](https://github.com/numpy/numpy/pull/28899), which deprecates and renames the internal function `round_` to `round` in `numpy.ma.core`. ### ✅...

I have applied Option 2 as suggested. The typing changes from #28917 have now been added into this PR. Kindly review again. Thank you! 🙏

"Thank you for the feedback! I completely understand. I’m reviewing the changes again and will make sure I fully understand what I’m submitting. I appreciate your patience!"just give me sometimes...

Hi everyone, I'm really sorry, but I wasn't able to fully fix the remaining issues in this PR. I’ve tried my best and learned a lot through this process. However,...