bpopup icon indicating copy to clipboard operation
bpopup copied to clipboard

beforeOpen and beforeClose

Open kouts opened this issue 10 years ago • 3 comments

Hi, great plugin, can you consider implementing beforeOpen and beforeClose callbacks in addition to onOpen and onClose?

Thanks.

kouts avatar Jun 11 '15 10:06 kouts

+1, although I believe the current onOpen is fired before the modal is shown. So actually that should be renamed to onBeforeOpen and the current onOpen should be fired after the animations are complete. The current onClose does seem to fire after animation is complete so we'd just need an onBeforeClose.

SnidelyWhiplash avatar Jul 11 '15 21:07 SnidelyWhiplash

Oh, I just saw your fork and pull request, would be great to get that in. :)

cc: @dinbror

SnidelyWhiplash avatar Jul 11 '15 21:07 SnidelyWhiplash

Thanks @SnidelyWhiplash , I have also implemented an autoOpen option but I'm not sure if if have done it right. I hope that gets in too.

kouts avatar Jul 11 '15 22:07 kouts