Dmitry Kazakov

Results 18 comments of Dmitry Kazakov

GCC spills function call arguments into unaligned stack, causing a crash

This bug in MSYS seems to be related as well: https://github.com/msys2/MSYS2-packages/issues/1209

Use of destructed object in lager::lenses::getset

Looking at the code it seems like `lager::lenses::attr` should also have this issue, though I cannot reproduce that for some reason.

Use of destructed object in lager::lenses::getset

There is also an issue that as long as `getter` has side-effects (e.g. expires the temporary) it is called during the set call, though the result is discarded.

Use of destructed object in lager::lenses::getset

Hi, @arximboldi! My main concern right now is that 'get()' part of the lens is executed during the 'set()' operation. And I don't know how to fix that properly. I...

Use of destructed object in lager::lenses::getset

Here is my proof-of-concept implementation, though it breaks `lenses::attr` severely :( https://github.com/arximboldi/lager/pull/161

xsimd::available_architectures() fails to skip CPU features when they are explicitly disabled by OS

Thanks for forward-porting the patch! :) It was in my todo-list, but I became distracted by the upcoming release :)

Add `Library/QuickLook` to the list of code resource bundles

I'm not really sure that is a correct fix, because this rule is missing from a package signed by normal codesign (from its CodeResources file). But at least it prevents...

Add `Library/QuickLook` to the list of code resource bundles

> So you are saying that codesign doesn't include this directory in its rules? It is a bit more complicated than it sounds. codesign does **not** include this directory in...

Fix double std::move on objects in 'lenses::getset' on set call

Hi, @arximboldi! The patch should now be ready for the final revew and merge. It fixes all the known issues with use-after-move and adds a comprehensive set of tests for...

Fix double std::move on objects in 'lenses::getset' on set call

Hi, @arximboldi! Happy holidays to you too! :) > I have some questions, firstly, you mention the view and set cases, what about the over case? Speaking truly, I haven't...