Dmytro Semenov

Results 127 comments of Dmytro Semenov

> Are you still in Kyiv ? In peacetime, I live in the satellite town to the north of Kyiv. I had to leave it once an artillery strike hit...

I'm not sure what might be wrong, on my side it works when I try to import it. If you know how `package.json` can be improved - feel free to...

I don't work with Angular, but if you know what's wrong with [package.json](https://github.com/dimsemenov/PhotoSwipe/blob/master/package.json) - feel free to send a PR.

Thanks for sharing, I'll see what I can do to make it easier. > It´s possible to use named exports and import like this? `import {PhotoSwipe, PhotoSwipeLightbox} from 'photoswipe';` Technically...

Inline embed isn't supported, yet, here is why: - if you just embed PhotoSwipe - it'll block vertical browser scroll on mobile, so the user might get trapped. The same...

@acwolff I'm referring to the gallery blocking the page scroll, so if the gallery occupies most of the viewport - there is no way to scroll.

you can do `counter:false`, or hide it via CSS. Default one is pretty simple https://github.com/dimsemenov/PhotoSwipe/blob/v5-beta/src/js/ui/counter-indicator.js

I'm not sure how to fix this. It seems SkyPack does not like the line `"./photoswipe.css": "./dist/photoswipe.css",` in [package.json](https://github.com/dimsemenov/PhotoSwipe/blob/master/package.json), but it's used as a shortcut to import CSS file: ```...

That's quite a curious issue. In v5 the click handler for the buttons is very simple, it's just `onclick` https://github.com/dimsemenov/PhotoSwipe/blob/4391b0d73ab66c9c20b9d17018ebb63a799ef169/src/js/ui/ui-element.js#L151 So I'm not sure why would it trigger twice sometimes....

Thank you very much, will try to include some of these in a core.