PhotoSwipe icon indicating copy to clipboard operation
PhotoSwipe copied to clipboard

Transparent zoom minus and plus (v5)

Open mrflix opened this issue 4 years ago • 2 comments

While I understand the usability concerns, my client insists that the plus and minus symbol inside of the magnifier glass should be transparent. Setting --pswp-icon-color-secondary: transparent makes the plus and minus disappear:

before

What I'd expect to happen is that the plus and minus mask the magnifier glass:

after

This would also enable setting the secondary color to half-transparent color that lets some of the background shine through.

mrflix avatar Oct 15 '21 14:10 mrflix

Thank you for the pull request, but it's way too much SVG code to add, it's almost the same as all existing icons combined. The existing icons are intentionally very simplistic and optimized for size.

So unless there is a way to make such icon much smaller, I'm not sure if it's a good idea.

Feel free to use the option zoomSVG to override the default icon, or use CSS.

dimsemenov avatar Oct 20 '21 14:10 dimsemenov

To taggle that problem, I make in my own css code –pswp-icon-color-secondary white except if --pswp-icon-color is white, in which case I make --pswp-icon-color-secondary black.

I think the icon is a little too small compared to the other icons.

acwolff avatar Oct 20 '21 15:10 acwolff