PhotoSwipe icon indicating copy to clipboard operation
PhotoSwipe copied to clipboard

v5-beta - Simple question: "data-cropped"

Open BilouMaster opened this issue 4 years ago • 1 comments

Hi,

The parameter data-cropped works like a charm and it's a relief to have it, but as a semantic psychopath I was just wondering why the parameter was named "data-cropped" instead of "data-pswp-cropped"...

Do you plan for a larger use of this parameter? I think it's related to PhotoSwipe so it should follow the semantic of data-pswp-src, data-pswp-srcset, data-pswp-width and data-pswp-height...

Not a big deal but still destabilising for a psychopath!

Best regards.

Joke

BilouMaster avatar Jun 25 '21 10:06 BilouMaster

That's a good point, I think the reasoning was that nobody uses data-cropped for anything, unlike data-src. I'll likely change it before the release.

dimsemenov avatar Jun 27 '21 16:06 dimsemenov