Generic DSN-specified server?
Hello,
Am I reading the code correctly in that [pgsql] section w/ dsn value has been fully replaced by having [pgsql] sections specify building out Postgres servers on EC2? I see this bit in tpch/infra/setup.py: https://github.com/dimitri/tpch-citus/blob/master/tpch/infra/setup.py#L140 but plenty still breaks with a [pgsql] section containing just a dsn value.
It looks like [citus] sections still accept and use a dsn value and I'm not seeing any specific Citus setup functionality beyond that. In particular, Citus is not a managed server type per https://github.com/dimitri/tpch-citus/blob/master/tpch/system.py#L70 Anything I'm missing? Can I use [citus] as a general DSN specification for non-Citus servers?
Hi. @mage2k. This project evolved following my own needs, and without enough time to spend on it to make everything meaningful and consolidated, sorry about that. Your analysis seems right to me, it used to be that [pgsql] was not managed and now it is (using a specific EC2 instance where we install PostgreSQL from packages). The [citus] resource type is still not managed, so you can use that with just a DSN.
It might be a good idea to implement back non-managed entry, maybe as a property of the existing [pgsql] and [citus] choices: it would be good to add support for managed Citus clusters too, after all.
Hi, @dimitri. Thank you. As the current [citus] behavior allows for specifying a DSN that, along with using the correct schema scripts, covers what I currently need.