pgloader icon indicating copy to clipboard operation
pgloader copied to clipboard

Published 20 hours ago • verified publisher icon dimitri

fix: mssql should only load data for the views specified by materialize views

Open conoremclaughlin opened this issue 4 months ago • 3 comments

conoremclaughlin avatar Feb 21 '24 01:02 conoremclaughlin

Hi @svantevonerichsen6906, thanks for the comments. I wanted to get the PR up for anyone who found it useful before cleaning it up.

I've removed the debug statements and have changed the parentheses to follow more of Lisp's standards. Unfortunately it's been quite some time since I learned Lisp in Berkeley and Lisp doesn't have a good formatter, so this is about as far as I can go for formatting. If you can give me some more specifics I can address them! Otherwise I would run the formatter across the file. The original code's indentation formatting was also off. It's also specifically noted that this flow was untested by the author, so anything is an improvement over the untested / completely broken materialize views code path we currently have for MSSQL.

Thanks!

conoremclaughlin avatar Mar 08 '24 04:03 conoremclaughlin

Fixes #1551.

conoremclaughlin avatar Mar 11 '24 20:03 conoremclaughlin