pgcopydb icon indicating copy to clipboard operation
pgcopydb copied to clipboard

Support timescaledb

Open Kesarwani-aditi opened this issue 1 year ago • 1 comments

This pull request adds support for the TimescaleDB extension in pgcopydb. The update includes specific pre and post pg_restore steps needed for TimescaleDB, requires data fetching and pg_dump operations. The changes ensure compatibility with TimescaleDB, enhancing the utility of pgcopydb for users leveraging TimescaleDB's capabilities.

Kesarwani-aditi avatar Jul 22 '24 05:07 Kesarwani-aditi

Thanks for working on timescaledb support! I think I remember that even when the PR used to work in the CI testing, it was failing for real users. Do you have a good testing setup outside of the CI?

cc @arajkumar

Thank you for your feedback! I appreciate it. Yes, we have set up manual testing outside of the CI environment to ensure that everything works correctly for real users. This includes various scenarios and edge cases to verify robustness and reliability. Please let me know if there are any specific areas you’d like us to focus on or if you have any additional concerns.

Kesarwani-aditi avatar Jul 24 '24 06:07 Kesarwani-aditi

@arajkumar Could you please review my code when you get a chance.

Kesarwani-aditi avatar Jul 31 '24 09:07 Kesarwani-aditi

@arajkumar Could you please review my code when you get a chance.

I see the following comment is not addressed yet. https://github.com/dimitri/pgcopydb/pull/849/files#r1693158692

arajkumar avatar Jul 31 '24 09:07 arajkumar

Nice work @VaibhaveS and @Kesarwani-aditi !

Thanks @dimitri for your early work on this.

arajkumar avatar Aug 08 '24 13:08 arajkumar