el-get icon indicating copy to clipboard operation
el-get copied to clipboard

[RFC] Is it time to switch 'el-get-allow-insecure to nil

Open manandbytes opened this issue 8 years ago • 5 comments

...and cut a new release? Please, do not merge yet as, in the first place, I'm looking for feedback if I'm doing something completely stupid ;-) I'm going update some commit messages and documentation later.

Unresolved issues

  • [ ] :construction_worker: username@ URL protocol. git clone user@server:project.git is a shortcut for git clone ssh://user@server/project.git
  • [ ] requireing url-parse introduces a circular dependency on loading some recipes, #1939 :worried:

manandbytes avatar Sep 02 '16 12:09 manandbytes

...and cut a new release?

We're currently in a "rolling release" model, which simplifies the questions of how to upgrade from an older release to a new one :) So before cutting a release we'd have to think about how to answer those.

npostavs avatar Sep 02 '16 18:09 npostavs

Hmm, perhaps we should tag some kind of release, since it seems that el-get is in melpa-stable right now (see #2438).

npostavs avatar Sep 03 '16 00:09 npostavs

As it turned out this PR's main feature is defcustom for the list of secure URL protocols, I'm not sure what to do next. I'm going to create a separate PR for this, is it :ok:?

These commits are not ready anyway and should not block the rest:

  • [RFC] Time to switch 'el-get-allow-insecure to nil
  • Semantic URL parsing
  • [WIP] Don't consider URL starting with 'username@' as secure

manandbytes avatar Sep 04 '16 09:09 manandbytes

I'm going to create a separate PR for this, is it :ok:?

Sure thing.

npostavs avatar Sep 04 '16 12:09 npostavs

I'm going to create a separate PR for this, is it :ok:?

Sure thing.

Done, #2441.

manandbytes avatar Sep 04 '16 16:09 manandbytes