Premature installation success notice

[dabrahams]

I just added failure notices to my local copy of el-get and tried to install package24 (on my emacs-23.x). The effect was strange: first I got a notice that installation succeeded, then a notice that installation failed. In fact, what failed was the "init" step, which seems to come after the determination of "installation" success. IMO, el-get should be changed so that installation is only considered complete when the package's init step has run once.

I'm submitting this ticket rather than simply fixing it myself because I want to separate addressing what looks like a pre-existing bug from the work on my new features

[dimitri]

On a quick review I think the problem is that the post install error notification hook is run when el-get-init fails. (add-hook 'el-get-post-error-hooks 'el-get-post-error-notification)

I suggest fixing which error message is used rather than adding what I think would be unnecessary complexity.

[dabrahams]

I disagree, but what you do about it is up to you