nphysics icon indicating copy to clipboard operation
nphysics copied to clipboard

Added Partial Serialization support + Missing Default & Debug derives

Open AnneKitsune opened this issue 5 years ago • 6 comments

Allows using serde to serialize rigidbodies among other things.

AnneKitsune avatar Feb 16 '19 05:02 AnneKitsune

I updated this to work with the latest version of nphysics: https://github.com/Laaas/nphysics

L-as avatar Apr 17 '19 18:04 L-as

@Laaas Thank you for updating this! Would you mind porting your changes in this PR, or perhaps open a new one?

Also, could you please double-check that the serde-serialize feature of nalgebra is really not enabled if ncollide's serde feature isn't enabled either. If I remember correctly there is some kind of Cargo bug that unifies all the features independently from the target.cfg statements. One way of checking this is to compile (in verbose mode) ncollide without the serde feature and see if the command line compiling nalgebra includes the serde-serialize feature or not.

sebcrozet avatar Apr 17 '19 18:04 sebcrozet

You are unfortunately right.

L-as avatar Apr 17 '19 19:04 L-as

@Laaas Thank you for checking. I guess one way of working around this is to add a feature serde-serialize = [ "serde", "nalgebra/serde-serialize" ] to ncollide instead of all those target.cfg.

sebcrozet avatar Apr 17 '19 19:04 sebcrozet

@sebcrozet what should I do with this PR then?

L-as avatar Apr 18 '19 12:04 L-as

You can make a pull request over my fork and it will update this pull request.

AnneKitsune avatar Apr 18 '19 16:04 AnneKitsune