nalgebra icon indicating copy to clipboard operation
nalgebra copied to clipboard

Do not explicitly set rkyv pointer size

Open arbor-arthur opened this issue 1 year ago • 0 comments

Cargo.toml currently sets rkyv-serialize-no-std = ["rkyv/size_32"] which prevents using rkyv with any other pointer size. It is best practice for libraries to not set the pointer size and allow binaries to choose the pointer size themselves. For myself, I patched this to rkyv-serialize-no-std = ["rkyv"], although I imagine that testing might require it to still be set in some circumstances?

arbor-arthur avatar Oct 18 '24 14:10 arbor-arthur