nalgebra icon indicating copy to clipboard operation
nalgebra copied to clipboard

Allow multiplying matrix by `Complex<>` on the left

Open tpdickso opened this issue 2 years ago • 2 comments

This simply inserts Complex<f32> and Complex<f64> into the left_scalar_mul_impl! macro alongside the primitives' trait impls.

tpdickso avatar Dec 24 '23 15:12 tpdickso

~~@Andlon would you happen to know what the CUDA error here is? Looks like it's a lockfile issue but I'm not yet familiar with the CI setup.~~ Nevermind, just found this! https://github.com/dimforge/nalgebra/pull/1333

tpdickso avatar Dec 24 '23 17:12 tpdickso

I think it would be good to have some very basic tests that verify that it indeed does work in some basic cases. I think just verifying that an arbitrary complex number multipled with an arbitrary matrix gives expected results should be enough, I can't imagine that much could go wrong here!

Andlon avatar Mar 28 '24 11:03 Andlon