nalgebra icon indicating copy to clipboard operation
nalgebra copied to clipboard
verified publisher icon dimforge

allow for nalgebra objects to be their own rkyv::Archive

Open zyansheep opened this issue 3 years ago • 1 comments

make it so that nalgebra objects archive as themselves. Allows for implementations on Matrix and other types to also work in a zero-copy environment. Draft PR, I will extend this to the other types soon. Any critiques or help with figuring out why I can't allow(unused_qualifications) in cfg_attr are welcome.

zyansheep avatar Jul 12 '22 02:07 zyansheep

Currently blocking on rust-num/num-complex#110 Once that is merged and relevant API usage of num-complex is fixed, this PR should be good to review.

zyansheep avatar Jul 14 '22 03:07 zyansheep

Thank you for this PR! Let’s not wait any further for num-complex and merge this without Complex support for now. Since we can’t have git dependencies, I copied the implementation of CustomPhantom into the nalgebra codebase (which is a fairly small piece. I added a reference to its original rkyv_wrappers repository).

I merged that by mistake (I mixed up remotes). I’ll make a new PR with the necessary CI fixes.

sebcrozet avatar Jan 13 '23 09:01 sebcrozet

rust-num/num-complex#110 was merged! Should I open another PR?

zyansheep avatar Jan 20 '23 17:01 zyansheep