alga icon indicating copy to clipboard operation
alga copied to clipboard

InnerSpace Angle Implementation Bug

Open shuyangsun opened this issue 4 years ago • 0 comments

The implementation of angle function on trait InnerSpace is incorrect. When calculating cang, instead of multiplying the inner product by the norms of two vectors, it should be dividing them.

The correct calculation should be let cang = prod.real().unscale(n1 * n2);.

shuyangsun avatar May 02 '20 18:05 shuyangsun