httptreemux

httptreemux copied to clipboard

add support for regexp routes

7

This pr adds support for regexp routes. The discussion is here: https://github.com/dimfeld/httptreemux/issues/85

jxskiss

Question: will regexp routes be considered?

2

Just a question, does regexp routes will be supported? Or if it's welcomed to accept PR to support regexp? Sometimes it's quite useful doing some migration work.

jxskiss

Document middleware usage

1

dimfeld

Remove routes

5

Since we can now add routes at runtime (using the mutex), I think it would be appropriate to provide a function to remove routes as well. Please excuse me if...

kabukky

In this PR we expose the LookupResults params field to be accessible to external code. This is to ultimately allow us to instrument `httptreemux` to add support for Datatdog APM....

devilleweppenaar

We would like to be able to instrument httptreemux for observability with Datadog, similar to what was done for [julienschmidt/httprouter](https://github.com/julienschmidt/httprouter) in [DataDog/dd-trace-go/contrib/julienschmidt/httprouter/httprouter.go](https://github.com/DataDog/dd-trace-go/blob/main/contrib/julienschmidt/httprouter/httprouter.go). In short, in order to build the Datadog...

devilleweppenaar

index out of range panic on bad URLs

1

👋 hello! we often see panics coming from our router when we get hit by people vuln scanning our app. we use lookupFunc to serve our frontend if no backend...

arussellsaw

[feature request] ability to handle all methods

1

curently there is no way to bind a handle to all methods. `TreMux.Handle` require me to specify the method name.

bokunodev

url :`/files/index.html` and `/files/` not handled. /files/ 404 /files/index.html redirected by `fs`. @dimfeld How can we handle `/files/`? ``` contextMux = app.TreeMux.UsingContext() contextMux.GET("/files/*", http.FileServer(Http.Dir(uploadPath))) ``` _Originally posted by @pedia in...

pedia

There is a vulnerability in Go url parsing. More on that here: https://www.oxeye.io/blog/golang-parameter-smuggling-attack In a nutshell, the method `Query()` ignores the error produced by another function when finding a semicolon...

f-hluchnik