OldTwitter
OldTwitter copied to clipboard
dimdenGD
Issue with profile hover in small modal views in Firefox, also rate limit strikes again
When mousing over user profiles in small modal views (not spanning past the bottom of the screen), the profile information can cause the modal view to expand downwards, requiring the modal to be scrollable, but spawning a scrollbar in the process unlike with already-scrollable modals, narrowing the content area and thus breaking formatting, and also frequently pushing the profile information itself out from under the cursor thereby breaking profile hover, behaviour does not appear to apply to already-scrollable modals, which don't spawn a scrollbar to begin with.
Firefox 117.0 on Windows 10
OldTwitter 1.8.0
Also rate limit is back again idk what to say about that, it's the usual, timeline sometimes loads new tweets, profiles and links are a no-go, clicking on tweets has like a 1/20 chance of producing a functioning modal view, I have to wonder if they're ever gonna get tired of breaking the bypasses be it on purpose or by accident.
I can't reproduce the bug with Firefox 117.0.1 on Windows 11
https://github.com/dimdenGD/OldTwitter/assets/26517362/25160803-e395-4556-85a7-97f7bfeeffdf
Hmmmm I see, it's still spawning a scrollbar in that video even when it shouldn't / long modals don't (visible in top right), but it being on Windows 11, scrollbars on that operating system don't narrow the content they're attached to since they're a narrow transparent overlay that hides when not in use, unlike the slightly more permanent fixture that is the default scrollbar on Windows 10, issue is as such partially specific to Windows 10 and below, though spawning a scrollbar at all is still inconsistent behaviour.
Small correction to my previous phrasing; scrollbar appearing does not appear to be a consequence of modal view expanding below bottom of screen, modal does not expand downwards at all in response to profile hover, scrollbar appears when profile hover causes the content inside the modal to expand past its bounds, in which case it does not expand but rather turns scrollable internally in order to render the profile information accessible, modal itself appearing to expand seems to be a consequence of the Win10 scrollbar narrowing it.
Preventing a visible scrollbar from spawning in this case would make the behaviour consistent between different operating systems and fix the most visible aspect of the bug, rendering profile hover above the modal and in cases where it goes below the bottom of the screen allowing the modal+hover view itself to be scrolled like with long modals instead of scrolling inside the modal could be a cleaner solution.
I reproduced the same bug with OldTwitter v1.8.1.3 installed on Firefox ESR 115.3.1 on Windows 10 21H2. As an improvement related to this issue, if the profile hover is positioned over the bottom of the screen, is it possible to make it fit within the screen by displaying it closer to the top of the mouse pointer?
This seems to cause the layout to collapse as the modal view area expands beyond the profile information and a scroll bar appears. I was able to avoid this problem by adding overflow:visible to the .modal-content CSS rule (the overflowing profile information was visible by scrolling the entire page). However, in DM's modal view, there was an issue where a scroll bar for the entire page was displayed when hovering over the user icon (although it was originally not displayed correctly on our side and scrolling in the modal view area was strange). Regarding this, it may be a good idea to set .user-preview to display:none only for DM's modal view.