Dmitriy

icon location Python developer, Rust enthusiast

Results 56 comments of Dmitriy

A large and controversial proposal: replace protocol implementation with kio

Hi! Looks interesting and more reliable than the current implementation. What about python 3.8+?

fix: check writer is closing in AIOKafkaConnection.send

@ods Hi! Could you take a look at this PR?

feat: add option to keep first empty rows for xlsx

> I don't know if the behavior is the same for other files Yes, the same. See first four tests https://github.com/dimastbk/python-calamine/blob/master/tests/test_base.py#L11

feat(opentelemetry-instrumentation-aiokafka): wrap getone instead of anext, add tests

@lzchen done

Fix aiokafka multiple values headers error.

Hi. I suggest add smth to tests: ```python async def test_send_and_wait(self) -> None: AIOKafkaInstrumentor().uninstrument() AIOKafkaInstrumentor().instrument(tracer_provider=self.tracer_provider) producer = await self.producer_factory() add_message_mock: mock.AsyncMock = ( producer._message_accumulator.add_message ) add_message_mock.side_effect = [mock.AsyncMock()(), mock.AsyncMock()()] tracer...

First two columns wrong in old xls files.

> Is there a way to only share them with e.g. contributors? Hi. You can send the file to me at [email protected]

First two columns wrong in old xls files.

Hi. Yes, or with a file. Can you open the file with biff viewer (like https://www.aldeid.com/wiki/BiffView) and find what type of cells have wrong values? Example for [base.xls](https://github.com/dimastbk/python-calamine/blob/master/tests/data/base.xls):

feat: Support standard environment variables

Thanks! And @felicijus thanks for review

memory leak even after called workbook.close

@pablo-voltaiq hi. Could you provide example code? Also see https://github.com/dimastbk/python-calamine/issues/42.

Some suggestions

Hi. > Sometimes an integer in a table is incorrectly converted to a floating point number. All numbers in Excel are stored as floats, so it's hard to detect the...