Dimitris Aragiorgis

> However, from what I see the current host is getting from knative directly. Yes. So `domainTemplate` etc. are currently ignored in the default deployment type (serverless / with KNative)....

> In serverless mode we take the host directly from Knative so for path based routing we only need the PathTemplate part really, we can use this to decide whether...

> so the domain needs to be synced between knative and kserve in order for mydomain.com to work which is why we should configure the domain in knative instead of...

Let me try explain a bit more. Let's assume we create a `sklearn-iris` ISVC in the kubeflow-user namespace. KServe will create: * `sklearn-iris-predictor-default` ksvc (KNative Service) * `sklearn-iris` Istio VirtualService...

> I think domain and domainTemplate can still be configured in Knative @yuzisun KNative uses host-based routing. So the domainTemplate will be in the format of `{{ .Name }}-{{ .Namespace...

@yuzisun first of all sorry for the late reply. Let me go through your comments/suggestions. > For example KServe can get the domain example.com from sklearn-iris-user1.default.example.com using the domainTemplate as...

Note that we already have support for setting the `urlScheme` in serverless deployments (see https://github.com/kserve/kserve/pull/2202). This is in-line with our suggestion where we have KServe decide on the final InferenceService...

@yuzisun just found time to finally switch to this. I will ping here once I have the PR ready with all the changes we discussed above. > we still need...

@yuzisun I am done with the refactor. Here is a summary of what I ended up implementing: * introduce `pathTemplate` in `ingressConfig` * if `pathTemplate` is given require `ingressDomain` *...

> Thanks @kandrio for the update! Just for the record I am @dimara :) @kandrio was the one that initially submitted the PR but he had to drop so we...