graphql-eslint icon indicating copy to clipboard operation
graphql-eslint copied to clipboard

feat: graphql-tag-pluck options

Open JimmyPaolini opened this issue 3 years ago • 5 comments

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1155

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] processor-without-config.spec: tests the processor as usual without any graphql-config using custom tags
  • [x] processor-with-config.spec: tests the processor with graphql-config configured to use custom tags

Test Environment:

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests and linter rules pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

JimmyPaolini avatar Sep 08 '22 19:09 JimmyPaolini

🦋 Changeset detected

Latest commit: bd27e4c4b1064cb6b9bd23f1acf1a8c3c33e3b3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 08 '22 19:09 changeset-bot[bot]

It looks like the test / Lint / eslint (pull_request) action failed due to insufficient resources so it just needs to be rerun

JimmyPaolini avatar Sep 12 '22 13:09 JimmyPaolini

It looks like the test / Lint / eslint (pull_request) action failed due to insufficient resources so it just needs to be rerun

@B2o5T this issue happens because of the shared-config task, ~~I'll fix it now~~ I think it's fixed now.

@JimmyPaolini I'll try to re-run

dotansimha avatar Sep 12 '22 14:09 dotansimha

ok seems to be fine now :) @B2o5T @TuvalSimha can you please take a look?

dotansimha avatar Sep 12 '22 14:09 dotansimha

Will take care of this in current sprint!

dimaMachina avatar Sep 13 '22 00:09 dimaMachina

released in @graphql-eslint/[email protected]

dimaMachina avatar Sep 23 '22 23:09 dimaMachina

@B2o5T Thanks so much for this!! 😄

JimmyPaolini avatar Sep 26 '22 13:09 JimmyPaolini