instagram-private-api icon indicating copy to clipboard operation
instagram-private-api copied to clipboard

url-regex-safe should be a peerdependency?

Open jedahan opened this issue 3 years ago • 0 comments

Bug Report

The url-regex-safe package is optional, so it should be a peer dependency.

Form

Put an [x] if you meet the condition, else leave [ ].

Requirements

  • [x] I've searched the Issues
  • [ ] I've read the basic concepts
  • [x] I'm using the latest version
  • [ ] I've debugged my code using the DEBUG variable.

Platform

  • [x] I'm using Node.js version 16.13.1
  • [ ] I'm using electron

Description

In https://github.com/dilame/instagram-private-api/commit/d69535de2c861a00485bc1dea99e6bcb52c88f96 , the url-regex-safe package was made optional, but npm install instagram-private-api still tries to compile and install url-regex-safe and therefore re2 (which causes the original problem closed in said commit).

By moving url-regex-safe to a peer dependency, other projects can use instagram-private-api

jedahan avatar Jan 11 '22 21:01 jedahan