Stable period determination not implemented

Open fnands opened this issue 3 years ago • 2 comments

Hi,

I had a look at the python version and if I'm not mistaken a stable history period is never determined as in section 2.4 of the paper.

Am I correct, or did I misunderstand the code? I tried to read the futhark implementation and it doesn't seem to be there either.

Mar 28 '22 15:03 fnands

Oh, I see there is a PR by @nhey that implements it. Can it be merged?

Apr 07 '22 07:04 fnands

I don't have the time to test the ROC implementation right now. Have you tried using the branch? I am planning a big overhaul of the whole package in the near future, and it will be included there

May 04 '22 16:05 mortvest