bfast icon indicating copy to clipboard operation
bfast copied to clipboard

improve Numpy implementation

Open 12rambau opened this issue 4 years ago • 2 comments

fix https://github.com/diku-dk/bfast/issues/28

12rambau avatar Jun 30 '21 18:06 12rambau

based on the modification you made in my last PR, I assume that you re working on develop. I think I can improve other stuff in this branch before pushing it. I cannot change it back into a draft, I'll ping you whennever i'm happy with it.

BTW I'm working on a cupy backend (the GPU numpy) so optimising one is leading to optimising the CPU as well

12rambau avatar Jul 01 '21 12:07 12rambau

@mortvest I'll let you check but this is a improved version of the python implementation, twice faster and more easy to maintain. I didn't change any logic so the results are exactly the same

12rambau avatar Jul 01 '21 15:07 12rambau