Dmitri Perunov

Results 64 comments of Dmitri Perunov
trafficstars

> @diimpp I see you've added some new comments after my fixes. Would you tell me in a comment, when you finish doing review? Previousely I thought your review was...

Hi, as https://github.com/Sylius/Sylius/pull/14449#issuecomment-1751823617 Loic mentioned, this most likely should target 2.0. For example new workflow SM are specifically done in yaml instead of php for 1.13.

> I think we can base this one to 1.13. But let's wait for other core team opinions. @loic425 I think we're keeping yaml at 1.13 and php configs are...

@senghe Hi, I've seen PR, but I'm not experienced with PostgreSQL, so I cannot say much. If nobody will do a review, I will try to reproduce over weekend. @Rafikooo...

@senghe Hi, does this solves your issue? https://github.com/Sylius/Sylius/pull/16012

Hello @maximehuran , can you please tell more why this change is necessary and what kind of issue it's solving?

I've reproduced the issue, it can be re-tagged as bug. /cc @jakubtobiasz 1. Select few countries for a channel ![image](https://github.com/Sylius/Sylius/assets/870747/05cf957c-ad64-401f-b91e-a8f5b2ff0f60) 2. Start checkout addressing step and see only previously selected...

PR looks good code-wise, but I wonder should there be a scenario to cover those cases? On separate note, - Administrator might wonder why channel has a country, but it's...

Hi, I've had this case in one of my projects before, company was selling by tons, but price was defined per KG on variants, which lead to massive performance hits...

> I do understand your point of view, many may in fact misrecognize this keyword. Top label synonyms by GPT: Yep.problem with `wholesale` it's a domain term, while PR makes...