async-tar icon indicating copy to clipboard operation
async-tar copied to clipboard

shared 'Header' behaviour

Open danieleades opened this issue 3 years ago • 1 comments

looking at the code, there's a lot of shared behaviour between the UstarHeader and GnuHeader types. There's also quite a lot of casting between the tops (which i guess is fine, since they're just representations of a vector of bytes anyway).

I wonder if the shared behaviour between these objects might be better represented as an Enum or as a trait, rather than being duplicated. Do you have any thoughts on that?

danieleades avatar Jul 06 '21 06:07 danieleades

This part was ported dirctly from the sync implementation, I wouldn't mind a cleanup of that code at all.

dignifiedquire avatar Jul 06 '21 12:07 dignifiedquire