doctl icon indicating copy to clipboard operation
doctl copied to clipboard
verified publisher icon digitalocean

Introduce vpc nat gateways api

Open asaha2 opened this issue 7 months ago • 1 comments

asaha2 avatar May 16 '25 21:05 asaha2

Hey ! can you add the integration tests ?

harshmaru7 avatar Jun 16 '25 13:06 harshmaru7

@harshmaru7 are the integration test suites required as we didn't have to add the same for recent products we added doctl support for (e.g. droplet autoscalers, vpc peering). Also they seem to be accomplishing the same objective as the unit tests that I've added with mocking the godo layer. Open to more feedback on this.

asaha2 avatar Jun 18 '25 16:06 asaha2

@harshmaru7 are the integration test suites required as we didn't have to add the same for recent products we added doctl support for (e.g. droplet autoscalers, vpc peering). Also they seem to be accomplishing the same objective as the unit tests that I've added with mocking the godo layer. Open to more feedback on this.

Please add the integration tests later on since unit tests tests logic in isolation, while integration ensure real-world usage actually works

harshmaru7 avatar Jun 18 '25 18:06 harshmaru7