digitalocean-cloud-controller-manager icon indicating copy to clipboard operation
digitalocean-cloud-controller-manager copied to clipboard

Published 20 hours ago • verified publisher icon digitalocean

Change FAKE_REGION to REGION

Open shatoboar opened this issue 2 years ago • 1 comments

This change addresses #511, and is needed for running the Digitalocean-CCM outside of Digitalocean.

shatoboar avatar Sep 09 '22 16:09 shatoboar

Hi, thanks for the comments :) I fixed your suggestions, could you take a look again?

shatoboar avatar Sep 13 '22 11:09 shatoboar

Hi @timoreimann , could you take one more look at it? Thanks :)

shatoboar avatar Sep 28 '22 09:09 shatoboar

I just tried this out locally by setting REGION to fra1 but getting an error:

1 main.go:67] Cloud provider could not be initialized: could not init cloud provider \"digitalocean\": failed to determine region: invalid region specified: fra1\n","stream":"stderr","time":"2022-10-04T07:55:19.141267853Z"}

Something is still off here. 🤔

timoreimann avatar Oct 04 '22 07:10 timoreimann

Got it: https://github.com/digitalocean/digitalocean-cloud-controller-manager/pull/513/files#r986547512

@shatoboar could you please address this one?

timoreimann avatar Oct 04 '22 07:10 timoreimann

Got it: https://github.com/digitalocean/digitalocean-cloud-controller-manager/pull/513/files#r986547512

@shatoboar could you please address this one?

Done :D

shatoboar avatar Oct 04 '22 08:10 shatoboar

@shatoboar looks like we need to run go mod tidy && go mod vendor as well.

timoreimann avatar Oct 04 '22 20:10 timoreimann

Doing some final testing tomorrow and will merge afterwards if everything goes well. 🤞

timoreimann avatar Oct 06 '22 17:10 timoreimann

Working as expected. Thanks for the contribution @shatoboar.

timoreimann avatar Oct 07 '22 19:10 timoreimann