digitalocean
Make Docker image public
Hi, you started publishing the docker image to ghcr.io here: https://github.com/digitalocean/app_action/pull/174, but the image is still private so we can't reallly use it.
Could you please make the image public? Also the action.yml file must be changed so that the action uses the pre-built image instead of building it everytime.
Docs for reference: https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility#configuring-visibility-of-packages-for-an-organization
Ah, sorry, this fell between the cracks.
Sadly, due to internal policy on the digitalocean org, we won't be making packages (which includes these images) public as that requires an org-wide change. Sorry for the inconvenience, we should've checked this before approving and merging the respective changes.
For now, we'll stay on the "build on demand" model that's implemented already.
@markusthoemmes :/ you could publish to digitalocean's DockerHub namespace instead. This is spending my CICD credits unnecessarily.
I believe I may have a solution for this.
https://github.com/tobyselway/app_action
This builds on demand, but then stores the resulting binaries in the action user's cache, and reuses it on subsequent runs.
If you want to iterate on this with me, let me know and I'll open up a PR
We're revisiting as we speak. @tobyselway that approach seems interesting as well! I'll take that into account. I wonder if we even need the Dockerfile in that world 🤔 . We could just built the go binary using the setup-go action there, I'd think?
https://full-stack.blend.com/how-we-write-github-actions-in-go.html seems quite relevant and interesting as well.
We're revisiting as we speak. @tobyselway that approach seems interesting as well! I'll take that into account. I wonder if we even need the Dockerfile in that world 🤔 . We could just built the go binary using the
setup-goaction there, I'd think?
Yes, almost definitely
The blog post I linked suggests that using setup-go is not a good idea as it might override whatever Golang version the users are setting for their flow. That seems to make sense to me.
TBC
Hi, are there any updates on this? It'd be great if we could address this issue in some way so that I can go back to depending on digitalocean/app_action rather than my own fork. If there's any other way forward I can help with let me know! 😄
This unnecessarily eats away my GH credits. If you're building to GHCR, then I think it's a better solution to just trigger the deployment directly through the DO API using a GH action.
Having to rebuild the action every run is absurd. If having a prebuilt image is impossible, at least allow us to cache it.
