php-ref icon indicating copy to clipboard operation
php-ref copied to clipboard

php-ref folder delets on push to origin

Open chrismec opened this issue 5 years ago • 7 comments

Hello, I dont think this is an issue with php-ref but i'm not sure how to fix it. I push vendor folder to origin (tsk, tsk, I know). When I do the php-ref folder never makes it. Do you have any idea how to keep this from happening? THnks

chrismec avatar Feb 14 '20 14:02 chrismec

Sorry if I’m stating the obvious but have you gitignored it?

twistedpixel avatar Feb 14 '20 15:02 twistedpixel

I dont think so. The only gitignores I have in my project are the ones that came with the packages installed. I've run check-ignore on the digitalnature, digitalnature/php-ref and digitalnature/php-ref/ref.php and get no output. Git exclude file is empty also.

chrismec avatar Feb 14 '20 16:02 chrismec

ahhh yissss. I finally found out what the issue was. dev-master packages are loaded as sub-modules which will never get committed I guess. Removed .git folder from php-ref, removed git cache for php-ref and then readded php-ref. $ rm -rf /vendor/NAME_OF_DEPENDENCY/.git $ git rm --cached /vendor/NAME_OF_DEPENDENCY $ git add /vendor/NAME_OF_DEPENDENCY Then added /vendor/**/.git to .gitignore to prevent future issues.

Thanks to this post for the help!

chrismec avatar Feb 14 '20 20:02 chrismec

I mean... committing your vendor directory is insane anyway lol. Why exactly do you want/need that in your repo?

twistedpixel avatar Feb 14 '20 21:02 twistedpixel

I know, I know, paranoia I suppose. What if some package of some version disappeared from the universe forever or worse some package of some version changed without a corresponding version change? I could recover or get back going again with my local copy but if I just commit the vendor I dont have to worry about it. Plus I try to keep my dependencies low anywho so its not a real burden...

chrismec avatar Feb 14 '20 21:02 chrismec

What you could do instead is clone the repo for each of your Composer dependencies onto your development machine(s) and pull down the changes every so often. That way, if a package goes missing or something, you can reference it in your composer.json as a local repo.

twistedpixel avatar Feb 14 '20 22:02 twistedpixel

oh, ive not played with local repo's yet. I'll check that out. Thanks!

chrismec avatar Feb 15 '20 19:02 chrismec