4cat icon indicating copy to clipboard operation
4cat copied to clipboard

Choose a consistent coding style

Open stijn-uva opened this issue 3 years ago • 5 comments

As more developers are contributing to 4CAT, the chance of mixing up different code styles increases and this can be inconvenient or confusing.

I propose we adopt Black for 4CAT, and then we don't have to worry about this anymore :-)

stijn-uva avatar May 02 '22 09:05 stijn-uva

I'll have to say goodbye to my beloved tabs but sounds like a good idea 👍

sal-uva avatar May 02 '22 09:05 sal-uva

It sounds nice to have that handled for us to some degree. I'm curious to see how it works in practice. I'll read up on Black.

dale-wahl avatar May 03 '22 07:05 dale-wahl

Black is beautiful.

Have you run it on 4CAT? You should and just see all the lovely formatted functions and loops and returns. The number of diffs is a little bit of a slap on the wrist to our own styles but, hey, it's to be expected. I'd miss tabs, but all my IDEs convert my tabs to spaces anyway.

I built a docker version off it and nothing crashed (that's my base level of testing/approval).

dale-wahl avatar May 31 '22 08:05 dale-wahl