comfyui-propost icon indicating copy to clipboard operation
comfyui-propost copied to clipboard

Faster noise

Open digitaljohn opened this issue 1 year ago • 5 comments

Uses pyfastnoisesimd to get over a 2x performance increase. Can test using:

Color Noise

python3 graingen.py output_image.png 800 600 2 30 1 42

ORIG: 0.21383213996887207 SIMD: 0.08792400360107422

Mono Noise

python3 graingen.py output_image.png 800 600 2 30 -1 42

ORIG: 0.06670999526977539 SIMD: 0.029595136642456055

digitaljohn avatar Feb 10 '24 21:02 digitaljohn

Quite borked at the moment, needs lots of work

digitaljohn avatar Feb 10 '24 21:02 digitaljohn

Appears to be working now...

digitaljohn avatar Feb 10 '24 22:02 digitaljohn

I feel even though the seed changes there is some sort of temporal consistency. Just trying a larger seed difference now.

digitaljohn avatar Feb 10 '24 22:02 digitaljohn

Step Change 1 between frames https://github.com/digitaljohn/comfyui-propost/assets/1425921/98a4a497-37c9-4b35-b10f-847065cf67d3

Step change 2 between frames https://github.com/digitaljohn/comfyui-propost/assets/1425921/d040dbf3-cc97-4b4d-ad0d-7bd0e4bd5244

digitaljohn avatar Feb 10 '24 22:02 digitaljohn

The noise may be a false herring, its the rest of the pipeline thats slowing things down.

digitaljohn avatar Feb 11 '24 11:02 digitaljohn