one-loader icon indicating copy to clipboard operation
one-loader copied to clipboard

Production ready?

Open guanzo opened this issue 7 years ago • 2 comments

First off, thanks so much for making this.

I love vue's single file components, it just makes sense. I'm brand new to React, and after some googling, it turns out that React recommends CSS in JS, which makes me want to puke. Not only are we going back to inline styles, but I'd have to put styling right next to component logic, camel case everything, etc.

/rant

Anyways, how do you feel about using this in production? Is it stable?

Side note: Vue-loader allows you to inject a scss file into every <style></style>, so you don't have to import variables, mixins, functions, etc into every component. Does your package allow this?

guanzo avatar Dec 01 '17 06:12 guanzo

Hi @guanzo

Thank you for your feedback! To be honest with you, I can't give a definitive answer to your questions as I haven't had a chance to use this loader in production yet. On the other side, I can't see why it wouldn't be production-ready since it only contains logic to split contents of a file into chunks of code and send them through configured loaders.

On SCSS @import - I believe it should work, will update one of the examples to include this code and check that it works.

MunGell avatar Dec 04 '17 09:12 MunGell

Just to add: at the moment the only way to test .one components is through running test runners like karma with headless browsers - similar to Vue components.

This is a limitation at the moment since pure React components could be tested in Node.js environment without launching browser.

MunGell avatar Dec 10 '17 19:12 MunGell