integreat-cms icon indicating copy to clipboard operation
integreat-cms copied to clipboard

Link targets after translation

Open svenseeberg opened this issue 4 years ago • 5 comments

If a page contains an internal link, the link target will not change during the translation process. As a result, users of other languages than the source language end up in the source language page. It should be our goal that users see the translated page. There might be some exceptions, where authors intentionally want users to end up in one page that is valid for all languages (we could argue that in these cases the live content function could be used).

Therefore we need a solution for substituting links somewhere, in order to end up in the translated page. One possibility is to "migrate" links during XLIFF import. The importer function could scan for all internal links, look for the translated page, and substitute the link target.

svenseeberg avatar Apr 24 '20 14:04 svenseeberg

This could be related to #1382

ulliholtgrave avatar May 16 '22 13:05 ulliholtgrave

I think it makes sense to fix this issue together with #1382 and #1383 . Other opinions?

svenseeberg avatar May 18 '22 14:05 svenseeberg

Yes, although I would differ between the generic search/replace and link search/replace, because the latter can be done with the lxml function rewrite_links(), see e.g.: https://github.com/digitalfabrik/integreat-cms/blob/7d91b2a40cbea712d16f1a734a1321d6dea6caad/integreat_cms/cms/views/linkcheck/linkcheck.py#L170-L173

Probably we can generalize the solution for the link replacement of the broken link checker and use it for this issue and #1383.

timobrembeck avatar May 18 '22 14:05 timobrembeck

We had a discussion in the Service Team, that it would be necessary to have this for the Maps feature as well.

vthejay avatar Jun 27 '22 09:06 vthejay

We got some more requests regarding that feature...guess we need to reschedule it because Q3/2022 is not realistic

dkehne avatar Jul 21 '22 06:07 dkehne

Any news on this feature and its possible implementation?

osmers avatar Jan 16 '23 11:01 osmers

Any news on this feature and its possible implementation?

No, sadly nobody wanted to tackle this complex issue yet. I increased the prio of the ticket to increase the incentive a bit.

timobrembeck avatar Jan 16 '23 11:01 timobrembeck

The scope changed. We want to update all links during XLIFF import. That should make things easier.

svenseeberg avatar Feb 17 '23 15:02 svenseeberg

HIX and DeepL features are more important.

svenseeberg avatar Feb 17 '23 15:02 svenseeberg

Is this an issue we could tackle in Q3 possibly? Since HIX and DeepL are done now :)

osmers avatar Jun 26 '23 06:06 osmers

Oh and just wondering - if we now translate within the system, there is no need to upload xliffs anymore and thus no way to change internal links during upload. Any ideas how we can solve this?

osmers avatar Jun 26 '23 06:06 osmers

@timoludwig @svenseeberg we got another question regarding this feature - is there any chance that this can be done in Q3 bcs many municipalities really want to have the links point to the correct language? Sorry for nagging :)

osmers avatar Jul 10 '23 11:07 osmers

@osmers I can only speak for myself that I probably won't have time to fix this issue in the near future.

timobrembeck avatar Jul 10 '23 12:07 timobrembeck

How about somebody else? @svenseeberg @JoeyStk

osmers avatar Jul 21 '23 06:07 osmers

I also don't see myself tackling this issue in the near future - due to both lack of time and lack of experience in this field :/

JoeyStk avatar Jul 24 '23 15:07 JoeyStk