integreat-cms icon indicating copy to clipboard operation
integreat-cms copied to clipboard

Catch and handle errors of FCM

Open MizukiTemma opened this issue 9 months ago • 2 comments

Short description

This PR add an error handling for invalid FCM URL.

update This takes care of timeout exception too. I've totally forgotten that those two issues are related each other.

Proposed changes

  • Catch errors and show an error message to users
  • The error message is left universal (not specific to any error type) because many types are possible.

Side effects

  • The rendering after failing of a push notification is partially broken.
  • A question regarding this rendering: don't we want to redirect not no the create view but to the edit view becuase the push notification is saved in this case?
  • I'll suggest to fix the rendering in a separate PR/issue.

Resolved issues

Fixes: #2025 , #2790


Pull Request Review Guidelines

MizukiTemma avatar May 16 '24 11:05 MizukiTemma