integreat-cms icon indicating copy to clipboard operation
integreat-cms copied to clipboard

Add new POI category icons

Open MizukiTemma opened this issue 10 months ago • 4 comments

Short description

This PR adds two new POI category icons (mental health and shelter)

Proposed changes

  • Add constants and svg files for the new icons
  • (Still in clearing: adjust API response, see the issue page)

Side effects

  • What should be the german translation of "shelter"? Is it "Shelter" in German too? 😁

Resolved issues

Fixes: #2698


Pull Request Review Guidelines

MizukiTemma avatar Apr 03 '24 19:04 MizukiTemma

Code Climate has analyzed commit 007756e1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.8% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Apr 03 '24 19:04 codeclimate[bot]

I think Unterkunft is a suitable word for shelter :)

lunars97 avatar Apr 04 '24 17:04 lunars97

What should be the german translation of "shelter"? Is it "Shelter" in German too? 😁

I think "Unterkunft" certainly is an option, but in this case I'd probably prefer "Obdach" as it seems to have an immediate connection to the "Vernetztes Obdach" project. But maybe @f1sh1918 can give us some additional context on what the best translation for "shelter" would be :)

JoeyStk avatar Apr 07 '24 18:04 JoeyStk

@MizukiTemma and @JoeyStk Please use "Notunterkünfte" as the German translation for shelter. That is the exact wording that is desired for "VernetztesObdach".

FritjofK avatar Apr 09 '24 09:04 FritjofK