integreat-cms icon indicating copy to clipboard operation
integreat-cms copied to clipboard

Fix push notification bug

Open david-venhoff opened this issue 10 months ago • 2 comments

Short description

This pr fixes a problem that the best_translation method of push notifications prefers translations without title over translations with title.

Proposed changes

  • Only return the backend translation if it has a title

Side effects

Resolved issues

Fixes: #2726


Pull Request Review Guidelines

david-venhoff avatar Apr 03 '24 14:04 david-venhoff

Code Climate has analyzed commit 8e5270a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.8% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Apr 03 '24 15:04 codeclimate[bot]

@JoeyStk I have added a test for this bug

david-venhoff avatar Apr 11 '24 16:04 david-venhoff

Thanks :)

david-venhoff avatar Apr 15 '24 09:04 david-venhoff