integreat-cms
integreat-cms copied to clipboard
Add color to language model
Short description
Add static color labels to language model in order to improve understanding of statistics regardless of to which region it belongs.
Proposed changes
- Add static representative colors to languages
- Add color field to language model like in Poi Category
Side effects
None?
Additional info
Should be done before #1097
Resolved issues
Fixes: #2390
I am not sure whether I am doing it right or not. I would be glad to get some guidance :)
Code Climate has analyzed commit 84d0e6e6 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 82.6% (0.0% change).
View more on Code Climate.
@lunars97
Thank you for the updates 🙂
Could you add a color column in the region language tree (in the first picture, like the language list of network management) and a color circle or something like that in the region language node form (second picture, like the country flag)?
A new specification came after the Service-UI/UX-CMS monthly meeting on the last monday: only colors should be shown as choice which are not yet assigned to any language so one doesn't have to check the list every time when assigning a color to another language 🙏
A new specification came after the Service-UI/UX-CMS monthly meeting on the last monday: only colors should be shown as choice which are not yet assigned to any language so one doesn't have to check the list every time when assigning a color to another language 🙏
Can I then remove blocked and ui/ux labels and continue working on it?
A new specification came after the Service-UI/UX-CMS monthly meeting on the last monday: only colors should be shown as choice which are not yet assigned to any language so one doesn't have to check the list every time when assigning a color to another language 🙏
@osmers To this thema there is a suggestion as below and we want to hear your opinion.
If the language has no color, the blank choice will be shown
and when clicked on the drop down, the choice appears including colors that are assigned to other languages but with note which language is using the color
If the language has a color, it looks like this first
After clicking on the drop dow
In this way it's easier to swap colors (because one doesn't have to think about which color is free for a temporary assigment during the swap) and also you can see directly in the choice which color and language are paired.
- The demonstration above was done with less color choices to make screen shot of the choice list easier
@lunars97 I will push pushed this suggestion
A new specification came after the Service-UI/UX-CMS monthly meeting on the last monday: only colors should be shown as choice which are not yet assigned to any language so one doesn't have to check the list every time when assigning a color to another language 🙏
@osmers To this thema there is a suggestion as below and we want to hear your opinion.
If the language has no color, the blank choice will be shown
and when clicked on the drop down, the choice appears including colors that are assigned to other languages but with note which language is using the color
If the language has a color, it looks like this first
After clicking on the drop dow
In this way it's easier to swap colors (because one doesn't have to think about which color is free for a temporary assigment during the swap) and also you can see directly in the choice which color and language are paired.
- The demonstration above was done with less color choices to make screen shot of the choice list easier
@lunars97 I will push pushed this suggestion
Looks good and I like the fact, that we can see which color belongs to which language. I would also suggest to make the color field mandatory so that we do not end up with a language without color, ok?
@MizukiTemma thank you for improving it :)
Should we leave statistics page for now as it is? Because the proposed final design of the page on ticket #1097 is like this
I am receiving test error. Could someone help me to identify the testing file which is causing current error. I would appreciate it a lot :)
@osmers
Looks good and I like the fact, that we can see which color belongs to which language. I would also suggest to make the color field mandatory so that we do not end up with a language without color, ok?
Yup, we can do that 👍
@MizukiTemma thank you for improving it :) Should we leave statistics page for now as it is? Because the proposed final design of the page on ticket #1097 is like this
Sounds reasonable 👍 I've totally forgotten the issue 😅
I have added colors for WebApp Access and Offline Access to the original 🎨 figma file. Thanks for being so patient!
I have added colors for WebApp Access and Offline Access to the original 🎨 figma file. Thanks for being so patient!
@MizukiTemma hmm do we also need for Total Access? Currently we do not have a designated color for it, it uses default color, can I designate the default to total access then?
EDIT: I assigned the default color for TotalAccess. If it is okay, then we can leave it as it is...
I have added colors for WebApp Access and Offline Access to the original 🎨 figma file. Thanks for being so patient!
@MizukiTemma hmm do we also need for Total Access? Currently we do not have a designated color for it, it uses default color, can I designate the default to total access then?
EDIT: I assigned the default color for TotalAccess. If it is okay, then we can leave it as it is...
You can also use black (#000000) for Total Access. I have added it to the design.
@lunars97 Thank you so much 😸 it looks good to go!
Could you squash the commits and rebase?