integreat-cms
integreat-cms copied to clipboard
Move MatomoApiManager to separate app
Short description
Move MatomoApiManager to separate app, like we did before with deepl_api, gvz and summ_ai
Proposed changes
- Created matomo_api app and registered it
- Created apps.py file for MatomoApiManager
Side effects
- MatomoApi
Resolved issues
Fixes: #1737
Code Climate has analyzed commit fececac5 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 90.9% (50% is the threshold).
This pull request will bring the total coverage in the repository to 74.8% (0.0% change).
View more on Code Climate.
Please find my PR to move the MatomoApi to a separate app
- I had to disable one pylint test. I kept failing, although as far as I understood the message I already had solved it. It keep reporting, that I should put the relative imports to the bottom. But that was already the case.
- I'm still struggling with differentiating between utils and apps. Could you maybe give me a hint in the right direction when something is an app and when something is an util?
Thank you a lot in advance!
Thank you again for your review. I hope I have it correctly now. As suggested I removed the ready-function and the MATOMO_ENABLED variable
:rocket: