integreat-cms icon indicating copy to clipboard operation
integreat-cms copied to clipboard

Move MatomoApiManager to separate app

Open JoeyStk opened this issue 2 years ago • 2 comments

Short description

Move MatomoApiManager to separate app, like we did before with deepl_api, gvz and summ_ai

Proposed changes

  • Created matomo_api app and registered it
  • Created apps.py file for MatomoApiManager

Side effects

  • MatomoApi

Resolved issues

Fixes: #1737


Pull Request Review Guidelines

JoeyStk avatar Oct 13 '22 19:10 JoeyStk

Code Climate has analyzed commit fececac5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.8% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Oct 18 '22 09:10 codeclimate[bot]

Please find my PR to move the MatomoApi to a separate app

  • I had to disable one pylint test. I kept failing, although as far as I understood the message I already had solved it. It keep reporting, that I should put the relative imports to the bottom. But that was already the case.
  • I'm still struggling with differentiating between utils and apps. Could you maybe give me a hint in the right direction when something is an app and when something is an util?

Thank you a lot in advance!

JoeyStk avatar Oct 18 '22 10:10 JoeyStk

Thank you again for your review. I hope I have it correctly now. As suggested I removed the ready-function and the MATOMO_ENABLED variable

JoeyStk avatar Nov 14 '22 09:11 JoeyStk

:rocket:

svenseeberg avatar Nov 18 '22 14:11 svenseeberg