bitbox02-firmware icon indicating copy to clipboard operation
bitbox02-firmware copied to clipboard

Fixes #791: Adds WalletMatrix support via "matrix.json" file.

Open dcentrica opened this issue 3 years ago • 10 comments

Adds an informational meta-file about your wallet's features for auto-import into walletmatrix.app. See #791

dcentrica avatar Sep 16 '21 03:09 dcentrica

is the supported currencies about the currencies supported by the hw itself (including via thirdparty companion wallets) or just with the first party companion wallet? in the former case the list would get LONG with the ERC20 list, and in the latter case the list still isnt complete.

My1 avatar Sep 20 '21 23:09 My1

I think there is a general issue here in that walletmatrix seems to mix hardware wallet and software wallet features. Related discussion: https://github.com/bitcoin-dot-org/Bitcoin.org/issues/3509

benma avatar Sep 21 '21 08:09 benma

@My1

is the supported currencies about the currencies supported by the hw itself (including via thirdparty companion wallets) or just with the first party companion wallet? in the former case the list would get LONG with the ERC20 list, and in the latter case the list still isnt complete.

Fair question! Currencies should be restricted to those that are out of the box / default. In otherwords, if the device comes with a BTC and BCH "app" (Is that how BitBox02 refers to these?), then these should be the two currencies that will be listed.

dcentrica avatar Sep 21 '21 09:09 dcentrica

Apologies, the original PR was mistakenly using the v2 schema and should have been v3 which has been corrected.

@x1ddos

  • "HD" can be found in the schema at: wallets.properties.features.properties.hd
  • Added missing "security" features
  • Appreciate the list of additional security features. We're continually adding to our draft v4 schema, but as you'll appreciate, this space is moving so fast, no standard terms yet exist outside of those proposed in BIPs for example. We do need to leave it a while sometimes to see when other wallets implement a similar sounding feature and then pull a name for it out of you-know-where that covers it. So these additional features may well make it into future iterations.
  • Added missing "privacy" features
  • Sorted languages as requested, renamed ML to MS
  • Added "testnet"
  • Updated remaining features with "Y", "N", "P" ("Planned") accordingly.
  • Added missing "hardware" features

@benma A "Fake Wallet" is one that only contains a fraction of a person's holdings in order to "palm-off" a would-be attacker than thes are your only funds.

dcentrica avatar Sep 21 '21 10:09 dcentrica

@My1

is the supported currencies about the currencies supported by the hw itself (including via thirdparty companion wallets) or just with the first party companion wallet? in the former case the list would get LONG with the ERC20 list, and in the latter case the list still isnt complete.

Fair question! Currencies should be restricted to those that are out of the box / default. In otherwords, if the device comes with a BTC and BCH "app" (Is that how BitBox02 refers to these?), then these should be the two currencies that will be listed.

The bb02 has fixed functionality the question is now whether the companion wallet (bitboxapp/electrum/mew/etc) matters and just tge featureset of the first party companion is counted or all that is possible with the hardware.

But if applets are relevant then ledger would support no coins out of the box lol

My1 avatar Sep 21 '21 13:09 My1

I think there is a general issue here in that walletmatrix seems to mix hardware wallet and software wallet features. Related discussion: https://github.com/bitcoin-dot-org/Bitcoin.org/issues/3509

This is my point.

My1 avatar Sep 21 '21 13:09 My1

Is attestation mentioned somewhere aka the feature that companion wallets can verify the bitbox is real?

My1 avatar Sep 21 '21 13:09 My1

@My1 as promised, the list of supported currencies and a rationale is posted under "Which coins are supported in matrix.json?" at: https://walletmatrix.app/vendors.

dcentrica avatar Sep 28 '21 09:09 dcentrica

cool to know, one ambiguity tho would be tokens like USDT which exist on multiple networks, like Ether and Tron or whatever (granted Tron isnt listed in the first place but not sure if for example Ether Classic which is listed has anything relevant in terms of tokens.

My1 avatar Sep 28 '21 09:09 My1

@x1ddos @benma @My1 FYI, apologies for the long hiatus. I have since composed a "schema explorer" page where schema keys can be looked-up against a description of their desired contents: https://walletmatrix.app/schema/explorer-v3/.

Note also, there is an invite-only Schema repo where discussions occur as to future iterations of the schema. We're actively discussing schema v4. Perhaps further suggestions for schema changes can be raised there once you're happy with this PR for v3? Let me know who should be invited.

dcentrica avatar Jan 09 '22 18:01 dcentrica