pyld icon indicating copy to clipboard operation
pyld copied to clipboard

Framing - reset graph context after recursing through named graphs

Open pjohnston-wiley opened this issue 7 years ago • 4 comments

When framing a JSON-LD document with at least one named graph, the current graph (state['graph']) was not being reset after recursing through the named graphs. Since the code iterates in alphabetical order, this only manifested for objects in the default graph that had @ids greater than the @id of the first named graph. This would be a good test to put into the overall JSON-LD framing test suite, please let me know if you want a formal example.

pjohnston-wiley avatar Apr 27 '18 19:04 pjohnston-wiley

Hi, If you have a chance could you provide a test example? I'll try to get it into main json-ld.org test suite to avoid the same issue in other implementations. If you want to add a patch to that repo, that works too. Thanks, and apologies for the late response.

davidlehn avatar Jun 05 '18 19:06 davidlehn

sure - i may already have one in some of the posts i put on the WG issues list, e.g. this. I'm traveling this week but i'll try and put something together soon.

pjohnston-wiley avatar Jun 05 '18 21:06 pjohnston-wiley

There now

pjohnston-wiley avatar Jun 30 '18 00:06 pjohnston-wiley

Should this be merged since https://github.com/json-ld/json-ld.org/pull/663 is merged?

anatoly-scherbakov avatar Oct 18 '23 13:10 anatoly-scherbakov