forge icon indicating copy to clipboard operation
forge copied to clipboard

Asn1 validator node ed25519

Open aljones15 opened this issue 6 years ago • 8 comments

Adds:

  • ASN1 validators for der format ed25519 public and private keys
  • Adds the OID for ed25519 keys
  • Adds extract functions so node 12 ed25519 keys can be imported now.

aljones15 avatar May 21 '19 18:05 aljones15

Some of the docs in here make it seem like the functions are specific to node.js buffers, etc. -- when they aren't. The docs can mention that if you're using node's API that the functions will be particularly helpful, but they should lead by saying that the functions, for example, convert a DER-formatted PKCS#8 private key to a raw private key.

We may also want the functions to be something like publicKeyFromDer() and publicKeyToDer() ... or something that more closely approximates existing the forge API. I think we need a short bikeshedding around. cc: @mattcollier, @davidlehn

dlongley avatar May 21 '19 19:05 dlongley

@mattcollier sorry you had to change those consts but thanks for updating this.

aljones15 avatar Jul 17 '19 23:07 aljones15

@dlongley @aljones15 I'll handle Longley's comments.

mattcollier avatar Jul 18 '19 14:07 mattcollier

@davidlehn I leave it to you to approve/merge and publish this. I'm not an owner on NPM. Thanks!

mattcollier avatar Jul 18 '19 15:07 mattcollier

@dlongley @mattcollier this can be closed correct? another PR added this feature I believe.

aljones15 avatar Aug 15 '19 19:08 aljones15

I don't know what the status is, but so we can better track it I'm linking to that other PR: #697.

dlongley avatar Aug 18 '19 15:08 dlongley

#697 was merged and released causing conflicts here. If some of this patch should still be merged, please rebase and update as needed.

davidlehn avatar Sep 05 '19 02:09 davidlehn

if I recall correctly this PR is not needed because it turns out the ed25519 keys use a common DER format that we already have a validator for. I believe this can be closed @dlongley

aljones15 avatar Feb 16 '21 22:02 aljones15