droid icon indicating copy to clipboard operation
droid copied to clipboard

Better handling of filenames that are already URL escaped

Open DavidUnderdown opened this issue 6 years ago • 4 comments

We need to look at how best to handle file names that have already been URL escaped (eg they were downloaded via the browser). We're currently getting issues with double encoding, or if we have a mixture of files with and without encoding it can complicate the process of decoding.

DavidUnderdown avatar Apr 17 '19 09:04 DavidUnderdown

Hi @DavidUnderdown to clarify, this is specifically for the URI field that DROID outputs?

ross-spencer avatar Apr 17 '19 10:04 ross-spencer

@LauraDamianTNA can you clarify?

DavidUnderdown avatar Apr 17 '19 10:04 DavidUnderdown

Yes @ross-spencer, it is for the uri field. Will it cause issues for you if we don't (re-)encode file paths that are already encoded?

LauraDamianTNA avatar Apr 17 '19 14:04 LauraDamianTNA

Thanks Laura. If the URI field is the only one changing then that should be okay.

On Wed, Apr 17, 2019 at 4:37 PM Laura Damian [email protected] wrote:

Yes @ross-spencer https://github.com/ross-spencer, it is for the uri field. Will it cause issues for you if we don't (re-)encode file paths that are already encoded?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/digital-preservation/droid/issues/228#issuecomment-484117806, or mute the thread https://github.com/notifications/unsubscribe-auth/AByxXD8Z8cc10XnaYFd0DJ1IKbKOnrU6ks5vhzGvgaJpZM4c0qjv .

-- Ross Spencer Software Developer, Artefactual Systems Inc. www.artefactual.com

ross-spencer avatar Apr 17 '19 14:04 ross-spencer