daml icon indicating copy to clipboard operation
daml copied to clipboard

Keep the files in compiler/damlc/tests/daml-test-files in sync between the daml and canton repos

Open paulbrauner-da opened this issue 1 year ago • 1 comments

A subset of the files under compiler/damlc/tests/daml-test-files are manually copied to canton's enterprise/app/src/test/daml/DamlTestLfV21Files directory on an ad-hoc basis. This is what we'd like to achieve instead (from @daravep):

  • reorganise the test directories such that we can automatically pick the subset to run against canton too.
  • run the canton repository tests against a "released & published version" of the test dars
  • (maybe) move the enterprise-script tests to community and run it in the daml repo too

@samuel-williams-da noted that we should modify the tests to use try-submit now that it exists, instead of our custom expectation annotations. That way the canton test could run more of these files without having to understand these annotations.

The reason we'd like to reorganize the test directories is to decrease the chance that someone would forget to mark a test as "must be run on canton as well".

paulbrauner-da avatar Jan 15 '24 11:01 paulbrauner-da

Might want to wait on a discussion whether we merge repos.

basvangijzel-DA avatar Feb 06 '24 14:02 basvangijzel-DA