daml icon indicating copy to clipboard operation
daml copied to clipboard

Published 20 hours ago • verified publisher icon digital-asset

Disclosure testing invalid key hashes

Open carlpulley-da opened this issue 3 years ago • 1 comments

  • Fixes #13897

CHANGELOG_BEGIN

  • Engine/speedy-level tests for explicit disclosure (#14227): Test that invalid key hashes are rejected.

CHANGELOG_END

  • [x] remove issue comment for #13897
  • [x] rebase when https://github.com/digital-asset/daml/pull/14563 is merged
  • [x] ensure CI passes build

https://github.com/digital-asset/daml/pull/14563 adds in a template type/ID check following disclosed key lookups. As discussed on #13897, this is sufficient to validate the key hash being used.

Future PRs will add in additional testing as per https://github.com/digital-asset/daml/issues/14227

carlpulley-da avatar Aug 03 '22 15:08 carlpulley-da

If we’re confident it works (as mentioned in #13897 I’m not sure it does), I suggest to at least add a test that proves it.

cocreature avatar Aug 04 '22 10:08 cocreature

Plan is to close this PR in favour of https://github.com/digital-asset/daml/pull/14999

carlpulley-da avatar Sep 13 '22 16:09 carlpulley-da