daml
daml copied to clipboard
Split up create-daml-app integration tests
Those tests are currently way too slow and also flaky. I do think they have value but we can probably split them up a fair bit. I would suggest the following:
- Keep one test which runs through the getting started guide workflow. Specifically:
daml startnpm install(already with added puppeteer deps)npm start- Run through pupeteer steps
- Modify the files
- Run through pupeteer steps
- Move everything else, in particular the
yarn buildsteps into tests that only depend on the codegen & yarn. Could even use a genrule for the codegen and then ada_ts_libraryideally.
This should roughly cut the test time of 1 in half and 2 should get much much better caching and also doesn’t have to be exclusive.
Out of
//daml-assistant/integration-tests:create-daml-app-tests-proj-name PASSED in 192.2s
//daml-assistant/integration-tests:integration-tests PASSED in 207.7s
the former (CreateDamlAppTests.hs) contains only one test, and the latter (IntegrationTests.hs) contains several. So I think there are two subtasks here:
- [ ] reduce the work being done in the one test in CreateDamlAppsTests
- [x] #14281