citesphere
citesphere copied to clipboard
Story/cite 183 - For authors, editors, etc. there needs to be an import from the IsisCB
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn [ ]
into [x]
).
- [x] I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
- [x] I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
- [x] I do not have any sysout statements in my code or commented out code that isn’t needed anymore
- [x] I am not reformatting any files in the wrong format or without cause.
- [x] I am not changing file encoding or line endings to something else than UTF-8, LF
- [x] My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
- [x] I have added Javadoc/documentation where appropriate
- [x] I have added test cases where appropriate
- [x] I have explained any part of my code/implementation decisions that is not be self-explanatory
Please provide a brief description of your ticket
Right now, when adding/editing an author, editor, etc. an authority from Conceptpower or VIAF can be linked to it. There should be a third option to link it to an authority from the IsisCB.
The endpoint to query is: rest/authority/search/?query=einstein
Talk to Julia before starting to get you set up on the test server.
... Put ticket description here and add link to ticket ...
https://diging.atlassian.net/browse/CITE-183
Are there any other pull requests that this one depends on?
Anything else the reviewer needs to know?
IsisCB API is not returning anything as of now because of some recent updates made to it.
... describe here ...