citesphere
citesphere copied to clipboard
diging
Story/cite 184 Imported authorities need to store the source of the import
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn [ ] into [x]).
- [x] I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
- [x] I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
- [x] I do not have any sysout statements in my code or commented out code that isn’t needed anymore
- [x] I am not reformatting any files in the wrong format or without cause.
- [x] I am not changing file encoding or line endings to something else than UTF-8, LF
- [x] My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
- [x] I have added Javadoc/documentation where appropriate
- [x] I have added test cases where appropriate
- [x] I have explained any part of my code/implementation decisions that is not be self-explanatory
Please provide a brief description of your ticket
... Put ticket description here and add link to ticket ... https://diging.atlassian.net/browse/CITE-184 Currently, the only way we know where an imported authority came from is by looking at the URL. Instead, an AutorityEntry should store the id of the importer so we can link it to the import source.
Are there any other pull requests that this one depends on?
Previously closed PR: https://github.com/diging/citesphere/pull/262/files
Anything else the reviewer needs to know?
... describe here ... Tested the UI, The import source is populating VIAF and Conceptpower correctly in both create and list pages.
The viaf importer name seems to have the wrong property name, it comes up blank now (it works for conceptpower).