citesphere icon indicating copy to clipboard operation
citesphere copied to clipboard

Story/cite 132 1

Open sathish2379 opened this issue 10 months ago • 1 comments

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • [x] I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • [x] I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • [x] I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • [x] I am not reformatting any files in the wrong format or without cause.
  • [x] I am not changing file encoding or line endings to something else than UTF-8, LF
  • [x] My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • [x] I have added Javadoc/documentation where appropriate
  • [x] I have added test cases where appropriate
  • [x] I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

... Put ticket description here and add link to ticket ... Right now, a job is just marked as cancelled (for jobs that silently failed) but not aborted. The sync processor should check in regular intervals if the current job is still in progress or if it should be cancelled. https://diging.atlassian.net/browse/CITE-132

Are there any other pull requests that this one depends on?

Here is the previous PR: https://github.com/diging/citesphere/pull/212

Anything else the reviewer needs to know?

... describe here ...

sathish2379 avatar May 03 '24 19:05 sathish2379

Can one of the admins verify this patch?

diging-jenkins avatar May 03 '24 19:05 diging-jenkins

Make it so, Jenkins.

jdamerow avatar May 23 '24 17:05 jdamerow

Jenkins successfully deployed Citesphere to be reviewed!

diging-jenkins avatar May 23 '24 17:05 diging-jenkins

Not sure why, but the items table for a group is now empty.

jdamerow avatar May 23 '24 17:05 jdamerow