citesphere
citesphere copied to clipboard
diging
Story/cite 204
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn [ ] into [x]).
- [x] I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
- [x] I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
- [x] I do not have any sysout statements in my code or commented out code that isn’t needed anymore
- [x] I am not reformatting any files in the wrong format or without cause.
- [x] I am not changing file encoding or line endings to something else than UTF-8, LF
- [x] My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
- [x] I have added Javadoc/documentation where appropriate
- [x] I have added test cases where appropriate
- [x] I have explained any part of my code/implementation decisions that is not be self-explanatory
Please provide a brief description of your ticket
... Put ticket description here and add link to ticket ... Implementing an 'Add Reference' Button for All Groups in Citesphere with a Search Field Feature to Easily Add References to Group's Reference Field
https://diging.atlassian.net/browse/CITE-204
Are there any other pull requests that this one depends on?
Anything else the reviewer needs to know?
... describe here ...
-
layout is off
-
The author for the references string seems to be taken randomly
The next time it's "Haines R, 2019, What Makes Research Software Sustainable? An Interview Study With Research Software Engineers" If there are multiple authors, it should be "First author et al."
-
then clicking "Add", it takes a long time where the browser is not reacting. If the user clicks again, it adds the reference twice. There needs to be a loading indicator and the user should not be able to click the button again.
-
And I can add the same item as reference
- layout is off
- The author for the references string seems to be taken randomly
The next time it's "Haines R, 2019, What Makes Research Software Sustainable? An Interview Study With Research Software Engineers" If there are multiple authors, it should be "First author et al."
- then clicking "Add", it takes a long time where the browser is not reacting. If the user clicks again, it adds the reference twice. There needs to be a loading indicator and the user should not be able to click the button again.
- And I can add the same item as reference
- Updated the layout.
- For random author creation problem, I have sort the list by firstname.
- Added the loaded spinner.
- I tested adding same item as reference, It threw exception as expected. I tested it on item - "Self-Organization in Pattern Formation".
- The search results box that shows the reference search results needs to show author and year, not just title.
- Also the box needs to say "Reference Search Results"
- And the column with the add button should have a heading "Add as reference"
- The references input field in the "Add references" modal should be deleted; instead the modal should close when an add button is clicked.
When clicking on a reference after it has been added, the pop up is all empty. it needs to pull the information from the citation.
- When there are no search results, there should be a message that says so.
- search should also happen if you hit enter after entring a term
Also there is a bug, if I search for soemthing that yields results, it shows results. I click close without selecting something. I search for something that doesn't exist, it shows me no results. I click close. I search for something that should yield results, but now it shows me no results.